Added encoding argument to TextReuseCorpus and TextReuseTextDocument#89
Open
davidfuhry wants to merge 2 commits intoropensci:masterfrom
davidfuhry:master
Open
Added encoding argument to TextReuseCorpus and TextReuseTextDocument#89davidfuhry wants to merge 2 commits intoropensci:masterfrom davidfuhry:master
davidfuhry wants to merge 2 commits intoropensci:masterfrom
davidfuhry:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 86.77% 86.81% +0.04%
==========================================
Files 25 25
Lines 658 660 +2
==========================================
+ Hits 571 573 +2
Misses 87 87
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Windows
readLineswill expect text files to be encoded in Windows-1252.This would add an optional encoding argument to
TextReuseCorpusas well asTextReuseTextDocumentwhich can be used to explicitly specify the encoding of the input files (mostly UTF-8).As it defaults to "unknown" which is the default for
readLinesthis should maintain backward compatability.Edit: I forgot to mention that this specific issue can be worked around by setting
options(encoding = "UTF-8")before creating the corpus however this has some side effects so I still think having an encoding argument is the better way to deal with this.