added support for filter_id. closes #224#331
Open
aaronball85 wants to merge 1 commit intoropensci:mainfrom
Open
added support for filter_id. closes #224#331aaronball85 wants to merge 1 commit intoropensci:mainfrom
aaronball85 wants to merge 1 commit intoropensci:mainfrom
Conversation
Collaborator
|
Thanks for your patience with us getting to you on this @aaronball85! We will need to get the tests updated in this PR as well. @jmobrien outlined some of what needs to happen here. Would you be able to take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a filter_id argument for fetch_survey(). I've updated the code and documentation to reflect the change. Changes passed package tests. Also, I've tested the functionality with a filterId that I created with a Qualtrics survey and it worked as expected. Let me know what you think. Thanks!