Conversation
Only return_fst() and return_keras() remain.
Member
Author
|
Also cc @schnorr and @guilhermealles. |
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
======================================
Coverage 100% 100%
======================================
Files 45 46 +1
Lines 6900 6323 -577
======================================
- Hits 6900 6323 -577
Continue to review full report at Codecov.
|
This was referenced Aug 5, 2019
Closed
Closed
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements specialized data storage and retrieval. By working around
storr, we decrease memory consumption, and we increase speed for data frames and Keras models. Formats "fst", "keras", and "rds" are currently supported, and it will be easy to add more.This is an alternative to richfitz/storr#111 for specialized scenarios, with greater efficiency in those scenarios (ref: #907 (comment)). cc @nettoyoussef, @richfitz, @MarcusKlik. @kendonB and @cimentadaj, you might also be interested.
How it works
Select the format in
target()or by manually appending a "format" column to the plan.Created on 2019-08-05 by the reprex package (v0.3.0)
Implementation
drakenow uses a decoratedstorrinternally, which is just an ordinarystorrwrapped up in a reference class.Related GitHub issues and pull requests
Checklist
drake's code of conduct.testthatunit tests totests/testthatfor any new functionality.