Skip to content

Update cras_write() and test-cras_write() to resolve issue #17#18

Merged
jospueyo merged 4 commits intoropensci:masterfrom
wikisqueaks:cras-write-format
Aug 25, 2025
Merged

Update cras_write() and test-cras_write() to resolve issue #17#18
jospueyo merged 4 commits intoropensci:masterfrom
wikisqueaks:cras-write-format

Conversation

@wikisqueaks
Copy link
Contributor

Description

This pull request updates cras_write() and test-cras_write() to address formatting improvements described in issue #17.

  • Added periods between authors in cras_write()to better align with journal expectations
  • updated unit test test-cras_write()
  • ran devtools::test() to confirm passes locally.
  • corrected additional minor issue in get_roles() that was causing devtools::test() failure on clean checkout (inconsistent capitalization not in alignment with NISO html and the test-get_roles() function).

Notes for reviewers

The new implementation should maintain backward compatibility.

Please confirm the updated behavior matches the intended design outlined in the issue.

Fixes #17

@jospueyo jospueyo merged commit ade1b6e into ropensci:master Aug 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify punctuation of credit statement in cras_write()

2 participants