add translator between a predefined grammar and django's filter lookups#95
Open
juan-ignacio-sanchez wants to merge 6 commits intomasterfrom
Open
add translator between a predefined grammar and django's filter lookups#95juan-ignacio-sanchez wants to merge 6 commits intomasterfrom
juan-ignacio-sanchez wants to merge 6 commits intomasterfrom
Conversation
juan-ignacio-sanchez
requested review from
brunomichetti and
kaozdl
and removed request for
a team
juan-ignacio-sanchez
requested review from
nsantos16
and removed request for
kaozdl
brunomichetti
requested changes
Feb 9, 2021
Collaborator
brunomichetti
left a comment
brunomichetti
left a comment
There was a problem hiding this comment.
Can you add a minor explanation in the README?
| @@ -0,0 +1,26 @@ | |||
| start : query | |||
Collaborator
There was a problem hiding this comment.
Can you change " by ' in this file?
Comment on lines
+12
to
+18
| operator_map = { | ||
| ">": "__gt", | ||
| "<": "__lt", | ||
| "==": "__eq", | ||
| "is": "", | ||
| "null": "__isnull", | ||
| } |
Collaborator
There was a problem hiding this comment.
Same question here: Can you change " by ' in this file?
| from .parser import translate_query | ||
|
|
||
|
|
||
| class GrammarTest(TestCase): |
| %import common.WORD | ||
| %import common.NUMBER | ||
| %import common.ESCAPED_STRING | ||
| %ignore " " No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows django drips to write simpler Human readable queries to be applied to Drips
Examples
Usage
Changes include
Other comments
There is needed some work to include
ORbranching and stuff.