Skip to content

Conversation

@cehbrecht
Copy link
Collaborator

@cehbrecht cehbrecht commented Nov 19, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes issue #xyz
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?

Update and fixes.

This PR updates the tests and the dependencies for the latest clisops release (0.17.0). It also drops Python 3.10 support.

Does this PR introduce a breaking change?

No.

Other information

@cehbrecht cehbrecht self-assigned this Nov 19, 2025
@cehbrecht cehbrecht requested a review from Zeitsperre December 4, 2025 13:29
@cehbrecht
Copy link
Collaborator Author

@Zeitsperre this is a clean-up PR and I want to make a v0.16 release after merge. I like to make also a new release for clisops ... even before the regrid PR is merged.

Next year we will work on a new approach on a "fixing library" together with CEDA. This should make daops obsolete and I would move the remaining used functionality into rook ... or clisops when appropriate.

@Zeitsperre
Copy link
Contributor

Zeitsperre commented Dec 16, 2025

@cehbrecht I'm about to send along a bunch of changes to handle many of the test warnings.

Also, good call on adding the h5netcdf library. I think I removed it from the CLISOPS core dependencies a while back. Technically, it's only needed for writing out files, so I'd rather have it set as a dev dependency. I'll make that change as well.

Update: The only warnings emitted now are coming from clisops, so I think we're in the clear.

@cehbrecht
Copy link
Collaborator Author

@Zeitsperre please have a look at this PR. I will make a new release of daops and rook when merged.

Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cehbrecht cehbrecht merged commit f0bc7f8 into main Dec 17, 2025
6 checks passed
@cehbrecht cehbrecht deleted the update-clisops branch December 17, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants