feat(eth_subscribe): SubscribeFullPendingTransactions#60
Open
TuDo1403 wants to merge 2 commits intoronin-chain:mainfrom
Open
feat(eth_subscribe): SubscribeFullPendingTransactions#60TuDo1403 wants to merge 2 commits intoronin-chain:mainfrom
TuDo1403 wants to merge 2 commits intoronin-chain:mainfrom
Conversation
added 2 commits
April 11, 2025 15:26
… hashes when subscribing newPendingTransactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance the handling of pending transactions in the Ethereum client. The primary updates include adding support for full transaction objects in pending transaction filters and modifying related APIs to accommodate this new functionality.
Enhancements to Pending Transaction Handling:
ChainConfigandCurrentHeadermethods to thefilterBackendinterface inaccounts/abi/bind/backends/simulated.go.fullTxflag andtxsfield to thefilterstruct ineth/filters/api.goto support full transaction objects.NewPendingTransactionFilterandNewPendingTransactionsmethods ineth/filters/api.goto handle full transaction objects when thefullTxflag is set. [1] [2] [3]GetFilterChangesmethod ineth/filters/api.goto return full transactions if thefullTxflag is true. [1] [2]API and Subscription Updates:
SubscribeFullPendingTransactionsmethod to theClientinethclient/gethclient/gethclient.goto subscribe to full pending transactions.SubscribePendingTxsmethod ineth/filters/filter_system.goto handle full transaction objects.handleTxsEventmethod ineth/filters/filter_system.goto pass full transaction objects to filters.Test Enhancements:
TestPendingTxFilterFullTxineth/filters/filter_system_test.goto verify the functionality of pending transaction filters with full transactions.These changes collectively improve the flexibility and functionality of pending transaction filters, allowing developers to retrieve complete transaction details when needed.