ci: run check on pull requests #8
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a basic CI workflow that runs automated checks (linting, typechecking, and unit tests) on pull requests and pushes to the main branch. Additionally, it includes minor updates to example configurations to improve CI stability.
- Adds GitHub Actions workflow with lint, typecheck, and test jobs
- Increases Playwright navigation timeout from 30s to 60s for better CI stability
- Simplifies auth:ensure command invocation in example package
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/check.yml | New CI workflow that runs lint, typecheck, and unit tests on PRs and main branch pushes |
| examples/next-admin-auth/playwright.config.ts | Increases navigationTimeout to 60s for improved stability in CI environments |
| examples/next-admin-auth/package.json | Simplifies auth:ensure command from "npm exec playwright-kit" to "playwright-kit" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Build | ||
| run: npm run build | ||
|
|
There was a problem hiding this comment.
The build step is redundant here because the typecheck script already includes it. According to package.json, the typecheck script runs "npm run build && npm -w packages/auth run typecheck". Consider removing this step to avoid running the build twice.
| - name: Build | |
| run: npm run build |
Add basic CI in pull requests