Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

[MUOS-20] Allow downloading assets and screenshots#60

Merged
gantoine merged 5 commits intomainfrom
muos-20
Dec 2, 2025
Merged

[MUOS-20] Allow downloading assets and screenshots#60
gantoine merged 5 commits intomainfrom
muos-20

Conversation

@gantoine
Copy link
Member

@gantoine gantoine commented Jul 6, 2025

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #20

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR

Screenshots

@gantoine gantoine changed the title [MUOS-20] Allow donwloading assets and screenshots [MUOS-20] Allow downloading assets and screenshots Sep 3, 2025
@gantoine
Copy link
Member Author

gantoine commented Dec 2, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a great new feature for downloading game assets and metadata. The implementation is solid, with a new ImageUtils class to handle image processing and updates to the API and filesystem layers to support this.

I've identified a few areas for improvement:

  • Error Handling: There are a couple of places that could benefit from more robust error handling, particularly a potential IndexError when accessing screenshots and a broad try-except block that could be more specific. Making these changes will prevent unexpected crashes.
  • API Data Access: The code assumes the API will always return all expected fields. Using .get() for dictionary access would make it more resilient to API changes.
  • Code Quality: I've also left some suggestions regarding type hints, removing redundant code, and improving filename parsing for better maintainability and robustness.

Overall, this is a well-structured contribution. Addressing these points will make the new functionality even more reliable.

@gantoine gantoine merged commit a73da08 into main Dec 2, 2025
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Download game information and artwork alongside the ROM.

1 participant