Conversation
romanoprid
requested review from
JohnSteck9 and
user-nazar
and removed request for
JohnSteck9
xor3r
left a comment
xor3r
left a comment
There was a problem hiding this comment.
No major problems, can be merged.
lib/screens/catalog.dart
Outdated
| const SliverToBoxAdapter(child: SizedBox(height: 12)), | ||
| SliverList( | ||
| delegate: SliverChildBuilderDelegate( | ||
| (context, index) => _MyListItem(index)), |
There was a problem hiding this comment.
Maybe consider renaming _MyListItem to something more self-explanatory.
There was a problem hiding this comment.
Thanks. It will be edited soon.
There was a problem hiding this comment.
Try to name variables of the small size for readability
maksymbudzin
left a comment
maksymbudzin
left a comment
There was a problem hiding this comment.
This lab was chacked, everything is okay, please marge!
| defaultConfig { | ||
| // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html). | ||
| applicationId "com.example.hometask_flutter_v2" | ||
| applicationId "com.example.hometask_v_3" |
There was a problem hiding this comment.
version (v2, v3) shouldn't be a part of your app id (as your version will change regularly, while your package ID won't ever change after app is published)
|
@JohnSteck9 |
|
Good work |
| @@ -1,18 +1,3 @@ | |||
| # FlutterCourse | |||
| It is the repsitory from mobile development subject | |||
|
@maximlev0-9 |
7 participants
Here you can see the previous application which was remade and some new functionality was added. Here are two screens:
the first one is a list of items that you can add to the cart (the second screen) by clicking on the icon on the right side of an element. Also, you can delete items from the cart using the round icon on the right side of the element, see the total price of the added elements and click on the "buy" button which functional maybe will be added in the future.