massive cleanup and make clippy happy

[romaninsh]

Massive cleanup, but still more warnings remain

[Copilot]

Pull request overview

This PR performs a comprehensive cleanup of the codebase to satisfy Clippy lints and improve code quality, focusing on Rust best practices and idiomatic patterns.

Key Changes:

• Refactored module naming from column::column and expression::expression to column::core and expression::core for clarity
• Replaced Into trait implementations with From implementations (following Rust conventions)
• Renamed methods for better clarity (from_any_column → convert_any_column, DebugEngine::new → DebugEngine::wrap)
• Applied clippy suggestions including unnecessary reference removal, let-chain patterns, and simplified patterns

Reviewed changes

Copilot reviewed 41 out of 43 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
vantage-types/src/record.rs	Changed Into impl to From for better trait convention
vantage-table/tests/column_type_system.rs	Updated imports and method calls for renamed modules/methods
vantage-table/src/traits/table_source.rs	Renamed from_any_column to convert_any_column for clarity
vantage-table/src/traits/table_expr_source.rs	Updated imports to use column::core
vantage-table/src/traits/column_like.rs	Updated imports to use column::core
vantage-table/src/table/sets/*.rs	Removed unnecessary & references when passing self
vantage-table/src/table/impls/*.rs	Updated imports and removed unnecessary references
vantage-table/src/prelude.rs	Updated re-exports for renamed modules
vantage-table/src/mocks/mock_table_source.rs	Applied let-chain patterns and multiline formatting
vantage-table/src/column/mod.rs	Renamed column module to core
vantage-table/src/column/core.rs	New file (renamed from column.rs)
vantage-table/src/column/collection.rs	Updated imports
vantage-surrealdb/src/types/generic.rs	Changed .into_iter() to .iter() for clarity
vantage-surrealdb/src/macros.rs	Added #[allow(unused_imports)] for generated code
vantage-surrealdb/src/lib.rs	Re-enabled identifier module and Expr type alias
vantage-surrealdb/src/identifier.rs	Simplified trait implementations and expression creation
vantage-surrealdb/examples/expr.rs	Enhanced error handling with proper Result return types
vantage-expressions/src/traits/expressive.rs	Updated imports for renamed modules
vantage-expressions/src/mocks/select.rs	Changed .push_str(" ") to .push(' ') for efficiency
vantage-expressions/src/mocks/mock_builder.rs	Removed unnecessary .into() calls
vantage-expressions/src/lib.rs	Updated re-exports for renamed modules
vantage-expressions/src/expression/mod.rs	Renamed expression module to core
vantage-expressions/src/expression/*.rs	Updated imports and documentation
vantage-dataset/src/traits/mod.rs	Fixed comment indentation
vantage-dataset/src/mocks/csv.rs	Added Default implementation
vantage-dataset/src/im/mod.rs	Added type alias for complex storage type
surreal-client/tests/integration_cbor_types.rs	Changed Option<CborValue> to CborValue in API calls
surreal-client/src/types/standard.rs	Applied let-chain patterns, removed redundant casts, removed redundant to_string method, improved test assertions
surreal-client/src/engines/ws_cbor.rs	Applied let-chain patterns for cleaner nested conditions
surreal-client/src/engines/debug.rs	Renamed new to wrap for clarity
surreal-client/src/connection.rs	Updated method call to use renamed wrap
cbor-test/src/type1.rs	Changed .get(0) to .first() for clarity

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 50 out of 52 changed files in this pull request and generated 9 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.