Improvements and fixes on the develop branch#104
Open
Jolly-Pirate wants to merge 17 commits intoromancin:developfrom
Open
Improvements and fixes on the develop branch#104Jolly-Pirate wants to merge 17 commits intoromancin:developfrom
Jolly-Pirate wants to merge 17 commits intoromancin:developfrom
Conversation
MAINTAINER has been deprecated
Add RUTORRENT_VER argument for specific version. "--depth 1" only pulls the master branch, which can be behind on the most recent version.
Build script with override variables stored in .env. This provides a more flexible setup without having to update Dockerfile with frequent versions.
BuildKit and heredocs reduce the clutter in Dockerfile in multiline RUN commands. https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/
- Add DOCKER_REPOSITORY environment variable to the build.sh - Change buildkit version to latest - Edit environment variables defaults to Dockerfile
Jolly-Pirate
changed the title
Jolly-Pirate
force-pushed
the
develop
branch
from
4f2e15a to
3642010
Compare
The default SSL_ENABLED is off when running the container. However, when choosing to enable it with SSL_ENABLED="yes" after it was ran with no ssl, the ssl didn't work. This fix allows toggling between non-ssl and ssl when stopping/removing and restarting the container. Also, I deleted the redundant nginx_ssl.conf file, since the only difference with nginx.conf was the listening port; I enabled toggling the listening port with a sed command.
Adapted from the latest ruTorrent v4.0.2 config.php
Jolly-Pirate
changed the title
3 tasks
Jolly-Pirate
force-pushed
the
develop
branch
from
24b215d to
97c296b
Compare
logging fix for: tail: cannot open '' for reading: No such file or directory I think you forgot to add the --pid switch, which stops tailing when the process dies. Also, get the pid with pidof command, it's much simpler.
network=host doesn't do anything when building, only when running a container
Jolly-Pirate
force-pushed
the
develop
branch
3 times, most recently
from
dd55971 to
cdc70ea
Compare
Save the session every 12 hours instead of the default 20 minutes. This 300 sec setting is too fast and will thrash the disks. https://github.com/rakshasa/rtorrent/wiki/Performance-Tuning#session-save rakshasa/rtorrent#180 (comment)
rtorrent and libtorrent master branches removed autogen.sh. We need to use autoreconf before running ./configure. Also, the package autoconf-archive is needed to avoid errors during the autoreconfg step.
Jolly-Pirate
force-pushed
the
develop
branch
4 times, most recently
from
3e792a2 to
4cf9aab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.sh script in conjunction with a .env file
use docker BuildKit and heredocs to simplify the Dockerfile syntax
fix for errors and ssl
update default config.php as of version 4.0.2