Skip to content

Conversation

@Retasusan
Copy link

implement RBAC

what I've done

  • add content/ to .gitignore
    • this may not good
  • add conditional branch to IssueToArticle function
    • this may not good too
  • add allowe_author param to init.go, --init command
  • change type definition of yaml
  • add test for IssueToArticle

what I want to ask

  • As one of the developer, it is a hassle to check every time whether gic.config.yaml or the content directory has been pushed. Is it fine to add content or gic.config.yaml to .gitignore file?
  • In this implementation, specificaly in cmd/generate.go and pkg/converter/article.go file's below implements, all nil will treated as error. But in the RBAC, I want to ignore the non allowed user. How can I implement this ? Please give me some oracle...
for _, issue := range issues {
  article := c.IssueToArticle(issue)
  article.Export(conf)
}
func (a *Article) Export(conf config.Config) {
  // Build String
  text, err := a.Transform()
  if err != nil {
  panic(err)
}

@Retasusan Retasusan marked this pull request as draft July 27, 2025 11:20
@Retasusan Retasusan marked this pull request as ready for review July 27, 2025 11:45
@Retasusan Retasusan changed the title [WIP] implement RBAC implement RBAC Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant