Skip to content

Conversation

@smagill
Copy link

@smagill smagill commented Jul 25, 2020

Description

Adds a config file that enables Muse to analyze the project and report bugs and code quality issues.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v5.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@smagill
Copy link
Author

smagill commented Jul 25, 2020

This is Stephen from MuseDev. I saw that you recently installed the Muse App on this repo (thanks for checking it out!), but it needed some configuration to run successfully (it needed to know the list of required packages). This PR should get it working. Results are here if you're interested. There are quite a few issues listed there, but day-to-day it should be much quieter since the pull request integration only reports new issues (issues due to the code change).

@rokopt
Copy link
Owner

rokopt commented Jul 26, 2020

This is Stephen from MuseDev. I saw that you recently installed the Muse App on this repo (thanks for checking it out!), but it needed some configuration to run successfully (it needed to know the list of required packages). This PR should get it working. Results are here if you're interested. There are quite a few issues listed there, but day-to-day it should be much quieter since the pull request integration only reports new issues (issues due to the code change).

Wow -- you did my configuration for me! Here I thought I was going to have to read the documentation or something. :) Thank you!

I've put your configuration into a branch (https://github.com/rokopt/stellar-core/tree/muse-dev-support) so as to leave my fork's main branch even with upstream, and I've created a PR from a branch off that one to test introducing a bug (#2). Musebot does appear to be running; I'll watch out for its completion.

I'm closing this pull request, since I took your changes into a branch. Thanks again!

@rokopt
Copy link
Owner

rokopt commented Jul 26, 2020

I've put your configuration into a branch (https://github.com/rokopt/stellar-core/tree/muse-dev-support) so as to leave my fork's main branch even with upstream, and I've created a PR from a branch off that one to test introducing a bug (#2). Musebot does appear to be running; I'll watch out for its completion.

I did receive an "Internal Failure" from the Musebot run on that PR, so I filed a Github issue (I hope that was the right way of reporting it):

Muse-Dev/MuseDev#4

@smagill
Copy link
Author

smagill commented Jul 26, 2020

Yes, that's perfect (filing an issue). We're looking into it. I'll let you know once it's diagnosed so you can try again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants