Skip to content

feat(core): configure log file path from core config #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ltsochev-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(core): configure log file path from core config #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4687e55
feat(core): configure log file path from core config
ltsochev-dev Mar 13, 2026
a0a8e6b
Merge branch 'main' into feature/logpath-config
roflmuffin Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/coreconfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ bool CCoreConfig::Init(char* conf_error, int conf_error_size)
UnlockConVars = m_json.value("UnlockConVars", UnlockConVars);
AutoUpdateEnabled = m_json.value("AutoUpdateEnabled", AutoUpdateEnabled);
AutoUpdateURL = m_json.value("AutoUpdateURL", AutoUpdateURL);
LogFilePath = m_json.value("LogFilePath", LogFilePath);
}
catch (const std::exception& ex)
{
Expand Down
1 change: 1 addition & 0 deletions src/core/coreconfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class CCoreConfig
bool UnlockConVars = true;
bool AutoUpdateEnabled = true;
std::string AutoUpdateURL = std::string("http://gamedata.cssharp.dev");
std::string LogFilePath;

using json = nlohmann::json;
CCoreConfig(const std::string& path);
Expand Down
5 changes: 3 additions & 2 deletions src/core/log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
namespace counterstrikesharp {
std::shared_ptr<spdlog::logger> Log::m_core_logger;

void Log::Init()
void Log::Init(const std::string& logFilePath)
{
const std::string resolvedLogFilePath = logFilePath.empty() ? "counterstrikesharp.log" : logFilePath;
std::vector<spdlog::sink_ptr> log_sinks;
auto color_sink = std::make_shared<spdlog::sinks::stderr_color_sink_mt>();
#if _WIN32
Expand All @@ -18,7 +19,7 @@ void Log::Init()
#endif

log_sinks.emplace_back(color_sink);
log_sinks.emplace_back(std::make_shared<spdlog::sinks::basic_file_sink_mt>("counterstrikesharp.log", true));
log_sinks.emplace_back(std::make_shared<spdlog::sinks::basic_file_sink_mt>(resolvedLogFilePath, true));

log_sinks[0]->set_pattern("%^[%T.%e] %n: %v%$");
log_sinks[1]->set_pattern("[%T.%e] [%l] %n: %v");
Expand Down
3 changes: 2 additions & 1 deletion src/core/log.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <memory>
#include <string>

#include <spdlog/fmt/ostr.h>
#include <spdlog/spdlog.h>
Expand All @@ -9,7 +10,7 @@ namespace counterstrikesharp {
class Log
{
public:
static void Init();
static void Init(const std::string& logFilePath = "");
static void Close();

static std::shared_ptr<spdlog::logger>& GetCoreLogger() { return m_core_logger; }
Expand Down
3 changes: 3 additions & 0 deletions src/mm_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ bool CounterStrikeSharpMMPlugin::Load(PluginId id, ISmmAPI* ismm, char* error, s
return false;
}

Log::Close();
Log::Init(globals::coreConfig->LogFilePath);

CSSHARP_CORE_INFO("CoreConfig loaded.");

if (globals::coreConfig->AutoUpdateEnabled)
Expand Down