Skip to content

Front page course from list to cards#8

Open
AndreLZGava wants to merge 1 commit intoroelmann:masterfrom
AndreLZGava:course_initial
Open

Front page course from list to cards#8
AndreLZGava wants to merge 1 commit intoroelmann:masterfrom
AndreLZGava:course_initial

Conversation

@AndreLZGava
Copy link

@AndreLZGava AndreLZGava commented Sep 21, 2017

This is the best that we could do for now :)

@roelmann
Copy link
Owner

Hi Andre,
Sorry I wont be able to apply this pull as it stands. It's a good start, and would work for a single institution wanting this change, but I couldn't include it as it is into a community released theme.

  1. I think such a big change needs a setting to choose to apply it or not
  2. It would need to pass the Travis CI checks (and yes I do realise that means editing the core code you have copied into your changes, as I have had to do in other cases)

@AndreLZGava
Copy link
Author

No problems, I needed this, and now this is working for me as I expected, then I decided to submit, to try help the community, I don't know much about Moodle your theme helped me to understand somethings clearly, If I get more progress I submit again :)

@roelmann
Copy link
Owner

It is helpful and appreciated Andre and if you can use it as a base to work on and develop more (or I will when I get chance), then I think it will be a good improvement :) Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants