Remove seemingly needless overwrite of file bytes upon picking a file#5
Open
robholmes wants to merge 1 commit intorodydavis:masterfrom
Open
Remove seemingly needless overwrite of file bytes upon picking a file#5robholmes wants to merge 1 commit intorodydavis:masterfrom
robholmes wants to merge 1 commit intorodydavis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you open a file that you don't have write permissions for, picking the file will fail, couldn't understand why as I didn't think this should be writing to the file I'm picking to read.
After digging a bit deeper I can see that upon picking a file, the code will read all file bytes and then write them to the file, effectively overwriting the original file, with the same bytes. I tried to work out if there was a reason for this behaviour, and I can't see anything, but happy to stand corrected if there's a valid reason for this.
My proposed fix for this, simply removes the calls to
readAsBytesandwriteAsBytes, and returns a futureFileXwhich points to the file path, which then leaves it to the end-developer, as to whether they want to read or write to the picked file.I've tested this on the example app, and this seems to work correctly.