Rewrite Vector using list and small inversions#170
Draft
andres-erbsen wants to merge 1 commit intorocq-prover:masterfrom
Draft
Rewrite Vector using list and small inversions#170andres-erbsen wants to merge 1 commit intorocq-prover:masterfrom
andres-erbsen wants to merge 1 commit intorocq-prover:masterfrom
Conversation
9148b5c to
ebb2c24
Compare
99436e4 to
6d6d327
Compare
7b8e5f5 to
e71b904
Compare
e71b904 to
d2f675b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
This PR is WIP but illustrative enough to see the direction. The idea is to keep the same type but remove anything that looks archaic, aiming for easy portability from old vector rather than drop-in compatibility.
Compat strategy:
WIP steps:
The main consideration for potential renaming is that the following ought to be able to coexist (and be distinguishable):