Skip to content

clean up component dependencies of lia#150

Merged
andres-erbsen merged 2 commits intorocq-prover:masterfrom
andres-erbsen:early-lia
Jan 31, 2026
Merged

clean up component dependencies of lia#150
andres-erbsen merged 2 commits intorocq-prover:masterfrom
andres-erbsen:early-lia

Conversation

@andres-erbsen
Copy link
Collaborator

@andres-erbsen andres-erbsen commented May 31, 2025 •
edited
Loading

@andres-erbsen andres-erbsen force-pushed the early-lia branch 18 times, most recently from 5b5c1c9 to 8e7d182 Compare May 31, 2025 20:31
@andres-erbsen andres-erbsen mentioned this pull request May 31, 2025
Closed
@andres-erbsen andres-erbsen marked this pull request as ready for review May 31, 2025 22:33
andres-erbsen added a commit to andres-erbsen/fiat-crypto that referenced this pull request May 31, 2025
@andres-erbsen
adapt to rocq-prover/stdlib#150
b9498c7
andres-erbsen added a commit to andres-erbsen/bedrock2 that referenced this pull request May 31, 2025
@andres-erbsen
adapt to rocq-prover/stdlib#150
1838a8d
andres-erbsen added a commit to mit-plv/fiat-crypto that referenced this pull request Jun 1, 2025
@andres-erbsen
adapt to rocq-prover/stdlib#150
cccc050
andres-erbsen added a commit to mit-plv/bedrock2 that referenced this pull request Jun 1, 2025
@andres-erbsen
adapt to rocq-prover/stdlib#150 (#461)
d00605c
proux01
proux01 previously requested changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable at first glance

@andres-erbsen andres-erbsen force-pushed the early-lia branch 3 times, most recently from ab28487 to c0e6db0 Compare June 12, 2025 12:17
@andres-erbsen
Copy link
Collaborator Author

andres-erbsen commented Jun 12, 2025

I addressed the comments and rebased. I think this PR is likely to go stale again; please also make a decision about how to handle the remaining overlay.

proux01

This comment was marked as resolved.

Sign in to view

@proux01

This comment was marked as resolved.

Sign in to view
@andres-erbsen
Copy link
Collaborator Author

andres-erbsen commented Jun 12, 2025

I responded to comments, please take another look

CI says error: Failed to open archive (Source threw exception: error: unable to download 'https://github.com/andres-erbsen/VST/archive/early-lia.tar.gz': HTTP error 404 after the overlay commit

@andres-erbsen

This comment was marked as resolved.

Sign in to view
@andres-erbsen andres-erbsen reopened this Jun 13, 2025
@andres-erbsen andres-erbsen dismissed proux01’s stale review January 30, 2026 01:17

The requested changes were about submodule documentation changes that are no longer a part of this PR.

@andres-erbsen
Copy link
Collaborator Author

andres-erbsen commented Jan 30, 2026

This is now rebased and cleaned up. I intend to merge tomorrow. (The new check in the last commit was important to for checking that the rebase left subcomponent files in an instructive state.)

@andres-erbsen andres-erbsen merged commit 31865e3 into rocq-prover:master Jan 31, 2026
271 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@proux01 proux01 proux01 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andres-erbsen @proux01