Draft
Conversation
Contributor
Why not |
Villetaneuse
force-pushed
the
subtraction_natint
branch
from
a1a0b42 to
6f55010
Compare
Contributor
Author
This only prevents to use the lemmas with an unqualified name, right? They would still appear in But maybe both is better. |
This is the revival of an old PR in former repository. We add two axioms in NatInt to restrict the models to exactly the integers and the natural numbers (with `pred 0 = 0`). This allows us to prove lemmas such as `sub_succ` and then prove many properties of `sub` which are shared between the natural numbers and the integers. The Natural and Integer parts of Numbers are modified in consequence. The result should be completely compatible except for `mul_sub_distr_l` which had different variable names in Integers and Natural (we chose to keep it as it was in Integers). We also remove references to old NZAxiomsSig modules. This needs more polishing, so still a draft: - the case of `mul_sub_distr_l` should be decided - removing some `Private_` lemmas is possible (e.g. with `Let`), this would result in a cleaner PR - check exactly the before/after for a user importing PeanoNat, etc
Villetaneuse
force-pushed
the
subtraction_natint
branch
from
6f55010 to
493dc64
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the revival of an old PR in former repository.
We add two axioms in NatInt to restrict the models to exactly the integers and the natural numbers (with
pred 0 = 0). This allows us to prove lemmas such assub_succand then prove many properties ofsubwhich are shared between the natural numbers and the integers.The Natural and Integer parts of Numbers are modified in consequence. The result should be completely compatible except for
mul_sub_distr_lwhich had different variable names in Integers and Natural (we chose to keep it as it was in Integers).We also remove references to old NZAxiomsSig modules.
This needs more polishing, so still a draft:
mul_sub_distr_lshould be decidedPrivate_lemmas is possible (e.g. withLet), this would result in a cleaner PRFixes / closes #????