Use levels instead of separate entries for rewrite strategies#21722
Merged
coqbot-app[bot] merged 1 commit intorocq-prover:masterfrom Mar 10, 2026
Merged
Use levels instead of separate entries for rewrite strategies#21722coqbot-app[bot] merged 1 commit intorocq-prover:masterfrom
coqbot-app[bot] merged 1 commit intorocq-prover:masterfrom
Conversation
SkySkimmer
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
coqbot-app
bot
added
the
needs: full CI
We could use NEXT instead of explicit levels in most of these but to minimize changes I used explicit levels.
Member
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
ppedrot
approved these changes
Mar 10, 2026
Member
|
@coqbot merge now |
JasonGross
reviewed
Mar 10, 2026
| @@ -2223,8 +2223,12 @@ rewrite_occs: [ | |||
| ] | |||
|
|
|||
| rewstrategy: [ | |||
Member
There was a problem hiding this comment.
Shouldn't rewstrategy have gone away entirely?
JasonGross
reviewed
Mar 10, 2026
| rewstrategy2: [ | ||
| | "fix" ident ":=" rewstrategy1 | ||
| | LIST1 rewstrategy1 SEP ";" | ||
| | rewstrategy1 |
Member
There was a problem hiding this comment.
Is this parsing ambiguous with the list above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could use NEXT instead of explicit levels in most of these but to minimize changes I used explicit levels.