Group all operations on subterms in a single module, simplify on_branches#21681
Open
yannl35133 wants to merge 2 commits intorocq-prover:masterfrom
Open
Group all operations on subterms in a single module, simplify on_branches#21681yannl35133 wants to merge 2 commits intorocq-prover:masterfrom
yannl35133 wants to merge 2 commits intorocq-prover:masterfrom
Conversation
coqbot-app
bot
added
the
needs: full CI
yannl35133
force-pushed
the
guard-subterms
branch
from
a9ad8a1 to
e46d06f
Compare
github-actions
bot
added
the
needs: rebase
yannl35133
added
kind: redesign
yannl35133
force-pushed
the
guard-subterms
branch
from
e46d06f to
2090263
Compare
yannl35133
commented
Mar 5, 2026
Contributor
Author
yannl35133
left a comment
yannl35133
left a comment
There was a problem hiding this comment.
I split off the reimplementation of tree/automaton pruning since it is more difficult to write and to review. This should not change behaviour.
coqbot-app
bot
removed
request: full CI
yannl35133
changed the title
ppedrot
reviewed
Mar 7, 2026
| val is_norec : t -> bool | ||
| val is_inductive : env -> inductive -> t -> bool | ||
| val is_primitive : env -> Constant.t -> t -> bool | ||
| val is_primitive_positive_container : env -> Constant.t -> t -> bool |
Member
There was a problem hiding this comment.
If you want a faithful name this should rather be is_primitive_array, I find your choice extremely verbose.
Contributor
Author
There was a problem hiding this comment.
Not my choice, it's already used in get_recargs_approx. Plus it should be about more than arrays, but less than all primitives.
ppedrot
reviewed
Mar 7, 2026
yannl35133
force-pushed
the
guard-subterms
branch
from
2090263 to
6f67e5f
Compare
yannl35133
commented
Mar 9, 2026
| val is_norec : t -> bool | ||
| val is_inductive : env -> inductive -> t -> bool | ||
| val is_primitive : env -> Constant.t -> t -> bool | ||
| val is_primitive_positive_container : env -> Constant.t -> t -> bool |
Contributor
Author
There was a problem hiding this comment.
Not my choice, it's already used in get_recargs_approx. Plus it should be about more than arrays, but less than all primitives.
Comment on lines
1188
to
1196
| let (ci, (p,_), _iv, c, lbr) = expand_case renv.env (ci, u, pms, p, iv, c, lbr) in | ||
| let stack' = push_stack_closures renv l stack in | ||
| let stack' = filter_stack_domain cache stack_element_specif Fun.id ?evars renv.env p stack' in | ||
| let cases_spec = | ||
| branches_specif renv (lazy_subterm_specif cache ?evars renv [] c) ci | ||
| in | ||
| let cases_spec = Subterm.on_branches renv.env ci.ci_ind (lazy_subterm_specif cache ?evars renv [] c) in | ||
| let stl = | ||
| Array.mapi (fun i br' -> | ||
| let stack_br = push_stack_args (cases_spec.(i)) stack' in | ||
| let stack_br = push_stack_args (cases_spec i) stack' in | ||
| subterm_specif cache ?evars renv stack_br br') | ||
| lbr in |
Contributor
Author
There was a problem hiding this comment.
Subterm.on_branches can stop constructing a list when this code stops needlessly expanding the case: constructor arguments should just be pushed directly in the renv, they don't need to go in the stack in the first place.
coqbot-app
bot
added
the
needs: full CI
ppedrot
reviewed
Mar 10, 2026
yannl35133
added
the
request: full CI
coqbot-app
bot
removed
request: full CI
Member
|
@coqbot bench |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.