Skip to content

Fix rocqwc on tactics that end in Proof#21423

Open
JoJoDeveloping wants to merge 4 commits intorocq-prover:masterfrom
JoJoDeveloping:master
Open

Fix rocqwc on tactics that end in Proof#21423
JoJoDeveloping wants to merge 4 commits intorocq-prover:masterfrom
JoJoDeveloping:master

Conversation

@JoJoDeveloping
Copy link

The issue is fixed by making sure to not give any special treatment to the "Proof" keyword after seeing it the first time.

Closes #21422

I think that rocq wc is mostly undocumented, so I am not sure how to handle the yet-unchecked boxes. I am also not sure this requires adding to the changelog.

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.
    • Documented any new / changed user messages.
    • Updated documented syntax by running make doc_gram_rsts.

The issue is fixed by making sure to not give any special treatment
to the "Proof" keyword after seeing it the first time.
@JoJoDeveloping JoJoDeveloping requested a review from a team as a code owner December 12, 2025 20:01
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Dec 12, 2025

Hello, thanks for your pull request!
In the future, we strongly recommend that you do not use master as the name of your branch when submitting a pull request.
By the way, you may be interested in reading our contributing guide.

@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 12, 2025
@SkySkimmer SkySkimmer changed the title Fix issue 21442. Fix rocqwc on tactics that end in Proof Dec 14, 2025
@SkySkimmer
Copy link
Contributor

Any @rocq-prover/coqdoc-maintainers can handle this?

Copy link
Contributor

@Lysxia Lysxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think it's worth recording this in the changelog, in the 09-cli-tools section.

  • For the sake of a smaller diff, I would prefer a solution that extends the character rule with one that consumes a whole word. And only doing that for the proof lexer is fine (until someone complains about the other cases).

@JoJoDeveloping
Copy link
Author

JoJoDeveloping commented Dec 15, 2025

I would prefer a solution that extends the character rule with one that consumes a whole word.

I can't figure out what you mean by this or how it's related to making the diff smaller for this PR 🙈

@SkySkimmer SkySkimmer added the needs: progress Work in progress: awaiting action from the author. label Jan 5, 2026
@JoJoDeveloping
Copy link
Author

I added a changelog. I did not test that the added changelog entry works correctly because I could not get the documentation to build. If CI fails I would appreciate help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. needs: progress Work in progress: awaiting action from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Having tactics that end in Proof confuses rocqwc.

3 participants