Optimize non-applicative stack nodes#20048
Closed
Tragicus wants to merge 2 commits intorocq-prover:masterfrom
Closed
Optimize non-applicative stack nodes#20048Tragicus wants to merge 2 commits intorocq-prover:masterfrom
Tragicus wants to merge 2 commits intorocq-prover:masterfrom
Conversation
When unifying terms that both have a Case, Fix or Proj node in their arguments stack, unify and remove the longest suffix of the stack containing applicative nodes or the last nodes if none exists.
Contributor
Author
|
This should solve the performance issue in #19987. |
Contributor
|
@coqbot run full ci |
Contributor
|
🔴 CI failures at commit 03c0916 without any failure in the test-suite ✔️ Corresponding jobs for the base commit 818d1e0 succeeded ❔ Ask me to try to extract minimal test cases that can be added to the test-suite 🏃
|
Contributor
|
@coqbot run full ci |
Contributor
|
🔴 CI failure at commit dcac3d4 without any failure in the test-suite ✔️ Corresponding job for the base commit 25659d3 succeeded ❔ Ask me to try to extract a minimal test case that can be added to the test-suite 🏃
|
Contributor
|
You can reopen if you get it to work, or if you can convince us that the failures are correct behaviour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unifying terms that both have a Case, Fix or Proj node in their arguments stack, Coq tries to reduce the non-applicative stack node, so we know that the node will never be reduced unless an evar is instantiated. Hence we unify and remove the longest suffix of the stack containing applicative nodes or the last node if none exists.
Fixes / closes #????
make doc_gram_rsts.