fix malloc mmap implementation's header size#9
Open
chm46e wants to merge 1 commit intorockytriton:mainfrom
Open
fix malloc mmap implementation's header size#9chm46e wants to merge 1 commit intorockytriton:mainfrom
chm46e wants to merge 1 commit intorockytriton:mainfrom
Conversation
There seems to be a bug in malloc's mmap implementation. The old implementation used HEADER_SIZE_MASK, let the numbers speak: old header size: 4294967288 bytes new header size: 4 bytes diff: -4294967284 bytes (:D) Signed-off-by: chm46e <chm46e@duck.com>
Author
|
Let me be clear, I'm a newcomer to memory management. I found another logical error: So my proposals are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I am working on a similar project and am taking some guidance.
I was looking through your malloc implementation and found a logical error.
In the mmap call, you seem to have mixed up HEADER_SIZE_MASK and HEADER_SIZE
This probably hasn't been tested. (as allocations over 128kb are rare)
old header size: 4294967288 bytes
new header size: 4 bytes
diff: -4294967284 bytes (:D)