Conversation
Init 2elli/python-xdis:python-3.14 into rocky/python-xdis:python3.14
also is in crossversion testing now
Great - thanks! |
xdis/opcodes/opcode_314.py
Outdated
|
|
||
| init_opdata(loc, opcode_313, version_tuple) | ||
|
|
||
| # OP NAME OPCODE |
There was a problem hiding this comment.
When there are massive bytecode changes between versions, sometimes it is better and clearer to not inherit from 3.13 and instead just start from say opcode_3x.py.
This way, we also reduce the long inherit change down from 3.14 down to 3.x.
Your thoughts?
There was a problem hiding this comment.
I definitely think that's a good idea, I can try that and see how it looks.
|
This is getting large. Let's please split off the testing aspect from the 3.14 aspect so that each and be reviewed and decided on separately. Thanks. |
|
Got it @rocky, ill use a crossversion specific branch if I need to make more changes to testing. Thank you :) |
Python 3.14 Opcodes and Marshal 5 Support
fix merge issues from PR 174
Set self.version_triple. More to come...
4 participants
Creating a draft PR to better keep track.
Will update here more as soon as I can. Have been pretty busy but am making some good progress with manual and cross-version testing. Once I have the chance and I verify more ill be pushing up some changes.