Fix comment referring to AWS Kinesis in the Kafka impl#91
Open
diwu1989 wants to merge 1 commit intorockset:masterfrom
Open
Fix comment referring to AWS Kinesis in the Kafka impl#91diwu1989 wants to merge 1 commit intorockset:masterfrom
diwu1989 wants to merge 1 commit intorockset:masterfrom
Conversation
I think this kafka CloudLogWritableFile implementation was copy pasted from the Kinesis one and accidentally carried over some incorrect comments.
|
Thanks for the pull request. can you p sign the CLA so that we can commit your patch into master? instructions here: https://github.com/rockset/rocksdb-cloud/blob/master/CONTRIBUTING.md |
|
Hi @diwu1989 can you pl sign the CLA at https://github.com/rockset/rocksdb-cloud/blob/master/CONTRIBUTING.md so that we can merge this patch? |
1 similar comment
|
Hi @diwu1989 can you pl sign the CLA at https://github.com/rockset/rocksdb-cloud/blob/master/CONTRIBUTING.md so that we can merge this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this kafka CloudLogWritableFile implementation was copy pasted from the Kinesis one and accidentally carried over some incorrect comments.