Open
Conversation
783d8dc to
d871fb4
Compare
d871fb4 to
f36fd1a
Compare
Author
Author
|
I'll remove Travis eventually. CircleCI seems to be much faster. |
Author
|
Once this PR is merged, we'll require CircleCI build to pass before merging. I think it will make merging much safer. |
igorcanadi
reviewed
Feb 16, 2021
| std::shared_ptr<CloudRequestCallback> cloud_request_callback_; | ||
| }; | ||
|
|
||
| namespace test { |
Collaborator
There was a problem hiding this comment.
Could we move this implementation to the test file, so that we don't clutter the production binary?
igorcanadi
reviewed
Feb 16, 2021
| export AWS_ACCESS_KEY_ID | ||
| export AWS_SECRET_ACCESS_KEY | ||
|
|
||
| export SRC_ROOT=$(git rev-parse --show-toplevel) |
Collaborator
There was a problem hiding this comment.
Do we also need an integration test that actually uses S3?
Author
|
@mrambacher is going to have a similar PR that mocks the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the unit tests are not able to run because we use actual S3 storage for tests. We want to mock the S3 storage using local storage so that unit test run faster.
In this PR, I created a class
TestS3ClientWrapperwhich extendsAwsS3ClientWrapper. Also, updaterun_tests.shto disable all networking for docker container to confirm that this test runs locally.Before my changes,
run_tests.shnever completes. With my changes,run_tests.shcompletes all tests in 15 minutes. Breakdown as followed:db_test2db_basoc_testenv_basic_testcloud_manifest_testdb_cloud_testdb_test