Skip to content

Conversation

@MartinNicholls
Copy link

Found that "rocks create distro" did not use the latest rpm release following
rebuild of an unrelated Roll.
The resolveVersions was using the comparision operation from the File class
which uses getUniqueName() which has the package name and arch but not the release.

from if not dict.has_key(name) or e >= dict[name]:
to if not dict.has_key(name) or e.getName() >= dict[name].getName():
so that rpm release is include in comparision.

Fo

from if not dict.has_key(name) or e >= dict[name]:
to   if not dict.has_key(name) or e.getName() >= dict[name].getName():
so that rpm release is include in comparision.
@ppapadopoulos
Copy link
Contributor

I still need to look at this. This is a holdover from when version naming was highly inconsistent and this defaulted to dates. This should probably just use version information from the appropriate RPM python class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants