Skip to content

Comments

update to zig 0.15.0-dev.1048+f43f89a70#37

Merged
rockorager merged 4 commits intorockorager:zig-0.15from
kristoff-it:writergate
Jul 22, 2025
Merged

update to zig 0.15.0-dev.1048+f43f89a70#37
rockorager merged 4 commits intorockorager:zig-0.15from
kristoff-it:writergate

Conversation

@kristoff-it
Copy link

aside from trivial changes:

  1. code that was doing endianness conversion is now doing the conversion immediately as the struct is read.

  2. in TzInfo.parse et simila, a call to readUntilDelimiter that would read to a local buffer has been changed to instead return directly a temporary slice to buffer memory. this should preserve the original logic while also avoiding a unnecessary copy.

  3. in loadTimeZone we now provide a buffer to the reader, which should help with performance significantly considering that the parser does a good amount of small reads.

  4. in build.zig the zeit api is now namespaced under api. rest in peace usingnamespace.

aside from trivial changes:

1. code that was doing endianness conversion is
   now doing the conversion immediately as the
   struct is read.

2. in TzInfo.parse et simila, a call to
   readUntilDelimiter that would read to a local
   buffer has been changed to instead return
   directly a temporary slice to buffer memory.
   this should preserve the original logic while
   also avoiding a unnecessary copy.

3. in loadTimeZone we now provide a buffer to
   the reader, which should help with performance
   significantly considering that the parser does
   a good amount of small reads.

4. in build.zig the zeit api is now namespaced
   under `api`. rest in peace usingnamespace.
@kristoff-it
Copy link
Author

just realized that this version of zig might not be available in CI, so consider waiting for the current pending job to complete https://github.com/ziglang/www.ziglang.org/actions/runs/16316578678 and then set the minimum_zig_version to that (the current latest unstable build is too old)

the upper bound will be naturally set by the length
of the reader buffer provided to parseBlock
@sam701
Copy link

sam701 commented Jul 22, 2025

@rockorager I’m working on slog, which depends on this awesome library. Any chance you could merge this PR into a branch so we can start testing dependent packages before Zig 0.15 drops?

@rockorager rockorager changed the base branch from main to zig-0.15 July 22, 2025 13:53
@rockorager
Copy link
Owner

I made a zig-0.15 branch that we can keep up to date with zig master. I'll keep main targeting the latest zig release - so once 0.15.0 is tagged we can just merge that branch over.

Thanks for the PR, Loris!

@rockorager rockorager merged commit 06ec404 into rockorager:zig-0.15 Jul 22, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants