Open
Conversation
Contributor
There was a problem hiding this comment.
Review Summary
The implementation adds a cmd parameter to spawn PTY requests, allowing an initial command to be executed. The overall structure is clean and follows the existing patterns well.
Issues found:
- Partial write risk (server.zig:2273): The return value of
posix.writeis discarded, which could result in truncated commands for longer inputs. - Potential race condition (server.zig:2269): The command is written immediately after PTY creation, but the shell may not be fully initialized yet.
The client-side changes and UI integration look correct.
Review context: https://ampcode.com/threads/T-019bafe3-3f81-756d-b252-899591d296aa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add cmd option for prise.spawn enabling execution of a command from prise.spawn.
Closes #65 with a slight difference when specifying the command.