More icons with associated color and colorized long output #12
Closed
UnsaltedScholar wants to merge 2 commits intorockorager:mainfrom
Closed
More icons with associated color and colorized long output #12UnsaltedScholar wants to merge 2 commits intorockorager:mainfrom
UnsaltedScholar wants to merge 2 commits intorockorager:mainfrom
Conversation
Contributor
|
oof one of us will have to rebase #11 |
Contributor
Author
Hmmm... doesn't seem too bad I don't think. Will wait till repo owner provides comments on both PRs though in case they have different ideas. |
UnsaltedScholar
force-pushed
the
add-color-to-long-output
branch
from
77d31cd to
fe36d55
Compare
Owner
|
Could you separate these out into different PRs?
I'm not sure I like all the color of the long output. I'm definitely not a fan of the icon color being the filename color. I'll have to think about the rest 🤔 |
Contributor
Author
|
Will do, and I could add a command line option for the colored file name part if that would be more agreeable? |
Contributor
Author
|
@rockorager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds (optional) color to the long output and adds support for more file types with associated icon (with optional colors from language logos). Color choices based on eza colors along with personal config to match file name color to language icon/color.