Skip to content

fix stale reference bug when converting images #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rockorager merged 1 commit into from
Jan 14, 2026
Merged

fix stale reference bug when converting images #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Vaxis.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,27 +1013,29 @@ pub fn transmitImage(
self: *Vaxis,
alloc: std.mem.Allocator,
tty: *IoWriter,
img: *zigimg.Image,
img: *const zigimg.Image,
format: Image.TransmitFormat,
) !Image {
if (!self.caps.kitty_graphics) return error.NoGraphicsCapability;

var arena = std.heap.ArenaAllocator.init(alloc);
defer arena.deinit();

var img_modifiable = img.*;

const buf = switch (format) {
.png => png: {
const png_buf = try arena.allocator().alloc(u8, img.imageByteSize());
const png = try img.writeToMemory(arena.allocator(), png_buf, .{ .png = .{} });
break :png png;
},
.rgb => rgb: {
try img.convert(arena.allocator(), .rgb24);
break :rgb img.rawBytes();
try img_modifiable.convertNoFree(arena.allocator(), .rgb24);
break :rgb img_modifiable.rawBytes();
},
.rgba => rgba: {
try img.convert(arena.allocator(), .rgba32);
break :rgba img.rawBytes();
try img_modifiable.convertNoFree(arena.allocator(), .rgba32);
break :rgba img_modifiable.rawBytes();
},
};

Expand Down