fix(docker): auto-read version from package.json in all Dockerfiles#96
Merged
rockfridrich merged 1 commit intomainfrom Feb 1, 2026
Merged
fix(docker): auto-read version from package.json in all Dockerfiles#96rockfridrich merged 1 commit intomainfrom
rockfridrich merged 1 commit intomainfrom
Conversation
Key Dockerfile was missing NEXT_PUBLIC_VERSION, GIT_SHA, and BUILD_TIME build args entirely. All three Dockerfiles had stale hardcoded fallback 0.1.0 as the version default, meaning Railway builds never reported the correct version. Now all Dockerfiles extract version from the app's package.json at build time via .env.local, with build arg override still supported. Health endpoints use "unknown" as fallback instead of stale version strings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
🤖 Villa Code Review Bot✅ No critical issues foundCode looks clean! Ship it. 🚀 Reviewed 3 file(s) |
Contributor
|
🎉 Merged! Railway will auto-deploy to construction.villa.cash. Create |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NEXT_PUBLIC_VERSION,GIT_SHA, andBUILD_TIMEbuild args — health endpoint always reported stale fallbackpackage.jsonat build time via.env.local, with build arg override still supported"unknown"instead of hardcoded stale version stringsRoot Cause
Hub deployed
0.3.0-rc.2correctly because it already hadNEXT_PUBLIC_VERSIONas a build ARG (defaulting to0.1.0, but Railway was setting it). Key and developers Dockerfiles had no version ARG at all, so their health endpoints fell back to the hardcoded"0.3.0-rc.1.1".Test plan
curl https://key.villa.cash/api/health | jq .versionreturns0.3.0-rc.2curl https://docs.villa.cash/api/health | jq .versionreturns0.3.0-rc.2bun typecheckpasses (18/18)bun lintpasses (6/6, 0 errors)🤖 Generated with Claude Code