completed base weather app!#57
Open
Mystjerne wants to merge 1 commit intorocketacademy:mainfrom
Open
Conversation
| import "./App.css"; | ||
| import API from "./WeatherAPI"; | ||
|
|
||
| //The following is an example of class based implementation of React. |
There was a problem hiding this comment.
How was learning class based components?
You could port the project into a vitejs application if you wanted to.
| if (this.state.formSubmitted === true) { | ||
| this.setState({ formSubmitted: false }); | ||
| } | ||
| this.setState({ cityInput: e.target.value }); |
There was a problem hiding this comment.
you can use template literals to make your comments easier.
cityInput: ${e.target.value}
|
|
||
| console.log("AAAAAAAAA prop passed down auccessfully", submitted_city); | ||
|
|
||
| const handleResponse = (response) => { |
There was a problem hiding this comment.
Can remove this function its not really called
| import { React, useState, useEffect } from "react"; | ||
| import axios from "axios"; | ||
|
|
||
| export default function API(props) { |
There was a problem hiding this comment.
Can come back to add in .env for practice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.