Weather app#55
Open
Lili00ani wants to merge 3 commits intorocketacademy:mainfrom
Open
Conversation
Flashrob
reviewed
Dec 18, 2023
| import axios from "axios"; | ||
| import "./App.css"; | ||
|
|
||
| const OPEN_WEATHER_API_KEY = "58b6f653523bf7394917009e6410008c"; |
There was a problem hiding this comment.
Never commit your API key openly like so. This should only sit in the local .env file, and should never be commited or pushed to github. Please revise https://bootcamp.rocketacademy.co/2-full-stack/2.2-advanced-react/2.2.7-environmental-variables
Comment on lines
+34
to
+35
| rawData = response.data[0]; | ||
| return rawData; |
There was a problem hiding this comment.
since you name it cityGeoData hereafter, why not call it the same here?
| temperature: response.data.main.temp, | ||
| formInput: "", | ||
| }); | ||
| return rawData; |
There was a problem hiding this comment.
I think this will not work. You do not have any rawData defined in this block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.