Open
Conversation
Flashrob
reviewed
Dec 18, 2023
| @@ -0,0 +1 @@ | |||
| REACT_APP_API_KEY=6a3affea0dc3f2287d470f99deb8e2f2 No newline at end of file | |||
There was a problem hiding this comment.
never commit the .env file. Always include it in the .gitignore file and make sure to never commit and/or push the .env!!!
Please revise https://bootcamp.rocketacademy.co/2-full-stack/2.2-advanced-react/2.2.7-environmental-variables
| </form> | ||
| </div> | ||
| <div className="text-white"> | ||
| {this.props.icon !== "" && ( |
There was a problem hiding this comment.
Suggested change
| {this.props.icon !== "" && ( | |
| {this.props.icon && ( |
| }; | ||
|
|
||
| render() { | ||
| return <></>; |
There was a problem hiding this comment.
Why use a component if you do not return anything? Might as well just use a simple JS Script without any React functionalities. With function components you could make it a custom hook if you need state, useWeatherAPI for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.