Skip to content

Conversation

@Artuomka
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 12, 2026 09:05
@Artuomka Artuomka enabled auto-merge January 12, 2026 09:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the columns_view field to the nested table_settings object in the get table rows response. The majority of the changes are formatting updates converting spaces to tabs across multiple files.

Changes:

  • Added columns_view field to the table_settings nested object in the response returned by GetTableRowsUseCase
  • Converted indentation from spaces to tabs across three files for consistency

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.

File Description
backend/src/entities/table/use-cases/get-table-rows.use.case.ts Added columns_view to table_settings response object (line 261); converted spacing to tabs
backend/src/entities/table-settings/personal-table-settings/personal-table-settings.controller.ts Formatting only - converted spaces to tabs
backend/src/entities/table-settings/personal-table-settings/dto/create-personal-table-settings.dto.ts Formatting only - converted spaces to tabs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

can_delete: can_delete,
can_update: can_update,
can_add: can_add,
columns_view: personalTableSettings?.columns_view ? personalTableSettings.columns_view : [],
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The columns_view field is being added to the table_settings object, but the TableSettingsInRowsDS class definition (in found-table-rows.ds.ts) does not include this field. This will cause a type mismatch and the field won't be properly documented in the API schema. You need to add the columns_view field to the TableSettingsInRowsDS class with the appropriate @ApiProperty decorator.

Suggested change
columns_view: personalTableSettings?.columns_view ? personalTableSettings.columns_view : [],

Copilot uses AI. Check for mistakes.
can_delete: can_delete,
can_update: can_update,
can_add: can_add,
columns_view: personalTableSettings?.columns_view ? personalTableSettings.columns_view : [],
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent default value for columns_view. At the root level (line 234), columns_view defaults to 'undefined' when not present, but in table_settings it defaults to an empty array '[]'. This inconsistency could confuse API consumers. Consider using the same default value in both places for consistency.

Copilot uses AI. Check for mistakes.
@Artuomka Artuomka merged commit 4ce6ea4 into main Jan 12, 2026
25 checks passed
@Artuomka Artuomka deleted the backend_table_settings_fixes branch January 12, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants