Add Internal Role Exports and Imports #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vscheuber
requested changes
Nov 14, 2024
| */ | ||
| deleteInternalRole( | ||
| roleId: string, | ||
| deep?: boolean |
Contributor
There was a problem hiding this comment.
The parameter deep in the type definition does not appear to be used in the function implementation. It should be removed.
| */ | ||
| deleteInternalRoleByName( | ||
| roleName: string, | ||
| deep?: boolean |
Contributor
There was a problem hiding this comment.
The parameter deep in the type definition does not appear to be used in the function implementation. It should be removed.
| * @param {boolean} deep deep delete (remove dependencies) | ||
| * @returns {Promise<InternalRoleSkeleton[]>} a promise that resolves to an array of internal role objects | ||
| */ | ||
| deleteInternalRoles(deep?: boolean): Promise<InternalRoleSkeleton[]>; |
Contributor
There was a problem hiding this comment.
The parameter deep in the type definition does not appear to be used in the function implementation. It should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to export and import internal roles for Cloud and ForgeOps deployments.
This PR should be merged in prior to the PR named "Update Full Config Export with new Imports and Exports" that updates the full config export/import since that PR will rely on the changes from this PR.