Skip to content

Conversation

@darkgnotic
Copy link
Contributor

Remove the uncaught promise that was causing unhandled rejection crashes.

@darkgnotic darkgnotic requested a review from grgbkr January 16, 2026 23:02
@vercel
Copy link

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
replicache-docs Ready Ready Preview, Comment Jan 16, 2026 11:03pm
zbugs Ready Ready Preview, Comment Jan 16, 2026 11:03pm

Request Review

@github-actions
Copy link

🐰 Bencher Report

Branchdarkgnotic/fix-and-reenable-row-catchup-test
TestbedLinux
Click to view all benchmark results
BenchmarkFile SizeBenchmark Result
kilobytes (KB)
(Result Δ%)
Upper Boundary
kilobytes (KB)
(Limit %)
zero-package.tgz📈 view plot
🚷 view threshold
1,783.60 KB
(0.00%)Baseline: 1,783.60 KB
1,819.27 KB
(98.04%)
zero.js📈 view plot
🚷 view threshold
242.90 KB
(0.00%)Baseline: 242.90 KB
247.76 KB
(98.04%)
zero.js.br📈 view plot
🚷 view threshold
66.56 KB
(0.00%)Baseline: 66.56 KB
67.89 KB
(98.04%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link

🐰 Bencher Report

Branchdarkgnotic/fix-and-reenable-row-catchup-test
Testbedself-hosted
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
src/client/custom.bench.ts > big schema📈 view plot
🚷 view threshold
132.88 ops/s x 1e3
(-4.32%)Baseline: 138.87 ops/s x 1e3
121.10 ops/s x 1e3
(91.14%)
src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers)📈 view plot
🚷 view threshold
2.45 ops/s x 1e3
(-0.66%)Baseline: 2.47 ops/s x 1e3
2.09 ops/s x 1e3
(85.11%)
src/client/zero.bench.ts > pk compare > pk = N📈 view plot
🚷 view threshold
59.82 ops/s x 1e3
(-6.56%)Baseline: 64.02 ops/s x 1e3
53.99 ops/s x 1e3
(90.25%)
src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers)📈 view plot
🚷 view threshold
3.79 ops/s x 1e3
(+0.20%)Baseline: 3.78 ops/s x 1e3
3.25 ops/s x 1e3
(85.71%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link

🐰 Bencher Report

Branchdarkgnotic/fix-and-reenable-row-catchup-test
Testbedself-hosted
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
1 exists: track.exists(album)📈 view plot
🚷 view threshold
13,044.14 ops/s
(-6.16%)Baseline: 13,899.68 ops/s
11,643.43 ops/s
(89.26%)
10 exists (AND)📈 view plot
🚷 view threshold
186,740.18 ops/s
(-8.49%)Baseline: 204,061.81 ops/s
165,418.85 ops/s
(88.58%)
10 exists (OR)📈 view plot
🚷 view threshold
3,940.13 ops/s
(-1.43%)Baseline: 3,997.10 ops/s
3,373.05 ops/s
(85.61%)
12 exists (AND)📈 view plot
🚷 view threshold
161,025.83 ops/s
(-10.68%)Baseline: 180,285.25 ops/s
146,030.73 ops/s
(90.69%)
12 exists (OR)📈 view plot
🚷 view threshold
3,135.49 ops/s
(-7.60%)Baseline: 3,393.56 ops/s
2,870.71 ops/s
(91.56%)
12 level nesting📈 view plot
🚷 view threshold
2,820.89 ops/s
(-4.69%)Baseline: 2,959.75 ops/s
2,499.45 ops/s
(88.60%)
2 exists (AND): track.exists(album).exists(genre)📈 view plot
🚷 view threshold
4,815.33 ops/s
(-7.76%)Baseline: 5,220.34 ops/s
4,381.06 ops/s
(90.98%)
3 exists (AND)📈 view plot
🚷 view threshold
1,934.72 ops/s
(-5.07%)Baseline: 2,037.95 ops/s
1,718.60 ops/s
(88.83%)
3 exists (OR)📈 view plot
🚷 view threshold
917.28 ops/s
(-10.05%)Baseline: 1,019.74 ops/s
857.81 ops/s
(93.52%)
5 exists (AND)📈 view plot
🚷 view threshold
298.41 ops/s
(-6.91%)Baseline: 320.56 ops/s
269.66 ops/s
(90.37%)
5 exists (OR)📈 view plot
🚷 view threshold
158.17 ops/s
(-6.46%)Baseline: 169.11 ops/s
141.63 ops/s
(89.54%)
Nested 2 levels: track > album > artist📈 view plot
🚷 view threshold
4,276.83 ops/s
(-6.35%)Baseline: 4,566.90 ops/s
3,841.51 ops/s
(89.82%)
Nested 4 levels: playlist > tracks > album > artist📈 view plot
🚷 view threshold
740.10 ops/s
(-1.29%)Baseline: 749.78 ops/s
637.08 ops/s
(86.08%)
Nested with filters: track > album > artist (filtered)📈 view plot
🚷 view threshold
3,559.50 ops/s
(-6.12%)Baseline: 3,791.35 ops/s
3,223.18 ops/s
(90.55%)
planned: playlist.exists(tracks)📈 view plot
🚷 view threshold
598.46 ops/s
(-4.13%)Baseline: 624.23 ops/s
538.03 ops/s
(89.90%)
planned: track.exists(album) OR exists(genre)📈 view plot
🚷 view threshold
163.28 ops/s
(-1.49%)Baseline: 165.76 ops/s
145.52 ops/s
(89.12%)
planned: track.exists(album) where title="Big Ones"📈 view plot
🚷 view threshold
7,159.15 ops/s
(-5.97%)Baseline: 7,613.60 ops/s
6,582.57 ops/s
(91.95%)
planned: track.exists(album).exists(genre)📈 view plot
🚷 view threshold
38.45 ops/s
(-2.84%)Baseline: 39.57 ops/s
33.76 ops/s
(87.82%)
planned: track.exists(album).exists(genre) with filters📈 view plot
🚷 view threshold
5,115.35 ops/s
(-4.91%)Baseline: 5,379.49 ops/s
4,611.03 ops/s
(90.14%)
planned: track.exists(playlists)📈 view plot
🚷 view threshold
3.85 ops/s
(-4.57%)Baseline: 4.03 ops/s
3.48 ops/s
(90.50%)
unplanned: playlist.exists(tracks)📈 view plot
🚷 view threshold
581.46 ops/s
(-4.43%)Baseline: 608.39 ops/s
525.18 ops/s
(90.32%)
unplanned: track.exists(album) OR exists(genre)📈 view plot
🚷 view threshold
43.67 ops/s
(-3.02%)Baseline: 45.03 ops/s
38.15 ops/s
(87.35%)
unplanned: track.exists(album) where title="Big Ones"📈 view plot
🚷 view threshold
54.42 ops/s
(-3.75%)Baseline: 56.54 ops/s
48.47 ops/s
(89.06%)
unplanned: track.exists(album).exists(genre)📈 view plot
🚷 view threshold
37.68 ops/s
(-4.37%)Baseline: 39.40 ops/s
33.70 ops/s
(89.43%)
unplanned: track.exists(album).exists(genre) with filters📈 view plot
🚷 view threshold
53.45 ops/s
(-3.19%)Baseline: 55.21 ops/s
47.96 ops/s
(89.73%)
unplanned: track.exists(playlists)📈 view plot
🚷 view threshold
3.75 ops/s
(-6.75%)Baseline: 4.03 ops/s
3.46 ops/s
(92.22%)
zpg: all playlists📈 view plot
🚷 view threshold
5.20 ops/s
(-7.80%)Baseline: 5.64 ops/s
5.03 ops/s
(96.79%)
zql: all playlists📈 view plot
🚷 view threshold
7.11 ops/s
(-7.37%)Baseline: 7.67 ops/s
6.15 ops/s
(86.61%)
zql: edit for limited query, inside the bound📈 view plot
🚷 view threshold
204,984.84 ops/s
(-2.63%)Baseline: 210,526.44 ops/s
177,926.42 ops/s
(86.80%)
zql: edit for limited query, outside the bound📈 view plot
🚷 view threshold
211,154.64 ops/s
(-2.44%)Baseline: 216,439.41 ops/s
170,575.04 ops/s
(80.78%)
zql: push into limited query, inside the bound📈 view plot
🚷 view threshold
100,618.51 ops/s
(-6.49%)Baseline: 107,598.66 ops/s
90,533.99 ops/s
(89.98%)
zql: push into limited query, outside the bound📈 view plot
🚷 view threshold
346,081.23 ops/s
(-11.80%)Baseline: 392,367.30 ops/s
306,425.54 ops/s
(88.54%)
zql: push into unlimited query📈 view plot
🚷 view threshold
305,338.38 ops/s
(-6.22%)Baseline: 325,597.12 ops/s
268,253.08 ops/s
(87.85%)
zqlite: all playlists📈 view plot
🚷 view threshold
1.61 ops/s
(-9.47%)Baseline: 1.77 ops/s
1.45 ops/s
(90.10%)
zqlite: edit for limited query, inside the bound📈 view plot
🚷 view threshold
68,239.82 ops/s
(-9.52%)Baseline: 75,415.80 ops/s
60,006.39 ops/s
(87.93%)
zqlite: edit for limited query, outside the bound📈 view plot
🚷 view threshold
69,089.96 ops/s
(-8.50%)Baseline: 75,511.05 ops/s
57,787.17 ops/s
(83.64%)
zqlite: push into limited query, inside the bound📈 view plot
🚷 view threshold
3,906.01 ops/s
(-3.27%)Baseline: 4,038.12 ops/s
3,652.17 ops/s
(93.50%)
zqlite: push into limited query, outside the bound📈 view plot
🚷 view threshold
86,830.37 ops/s
(-0.85%)Baseline: 87,576.95 ops/s
75,992.73 ops/s
(87.52%)
zqlite: push into unlimited query📈 view plot
🚷 view threshold
120,613.39 ops/s
(-2.00%)Baseline: 123,070.16 ops/s
102,422.94 ops/s
(84.92%)
🐰 View full continuous benchmarking report in Bencher

@darkgnotic darkgnotic added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 59bbaaa Jan 16, 2026
18 checks passed
@darkgnotic darkgnotic deleted the darkgnotic/fix-and-reenable-row-catchup-test branch January 16, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants