feat(zero): add support for timetz datatype #5417
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the PR #4671 adding support for
timedatatype, this adds thetimetzdatatype. Interestingly, everything to do so was already in place (like the timetz type), so we only have to slightly extend existing logic.You can find information about the pg types in postgres' datatype-date doc.
Tests were added to test the new behavior.
Note:
timeis actuallytime without timezoneand therefore adding this would only adding the correct mapping. Hence the added code is mainly related to supporttimezones and is similar to the code that is in place fortimestamp with timezone.Edit:
I tested this PR in our application test setup and with our application now as well. I was previously facing the error:
This PR solves our problems (test passes with it and ui works) and removes a blocker for us. The outcome is as expected.