Add 'path' to setCookie #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This event is raised by socket.io in the event of the websocket-server not being available and throwing an ERR_CONNECTION_REFUSED error. This is distinct and different from the `disconnect` event which ewd-client already caters for.
Added `connect_error` event.
When a user of an SPA hits page refresh or uses a bookmark as an entry point into the app, it is necessary to call the EWD.setCookie function in order to re-register the session and to map the session cookie to the new web socket. If the href has a different path to that when the token was first generated, you can end up in a situation where QEWD loses track of the session because it is seen as a new token. This modification allows one to prevent this undesirable behaviour by providing the ability to specify the cookie’s path and providing a sensible default for an SPA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user of an SPA hits page refresh or uses a bookmark as an entry
point into the app, it is necessary to call the EWD.setCookie function
in order to re-register the session and to map the session cookie to
the new web socket.
If the href has a different path to that when the token was first
generated, you can end up in a situation where QEWD loses track of the
session because it is seen as a new token.
This modification allows one to prevent this undesirable behaviour by
providing the ability to specify the cookie’s path and providing a
sensible default for an SPA