Skip to content

Update model #21

Open
MiriamCalafa wants to merge 9 commits intojazzy-devel-sygisfrom
miriam-devel
Open

Update model #21
MiriamCalafa wants to merge 9 commits intojazzy-devel-sygisfrom
miriam-devel

Conversation

@MiriamCalafa
Copy link

New wheels, metal spacers, launch color parameters, added components (encoder button, OLED screen)

Comment on lines +67 to +70
<joint name="${prefix}base_joint_spacers" type="fixed">
<parent link="${prefix}base_footprint"/>
<child link="${prefix}base_link_spacers"/>
<origin xyz="0 0 0" rpy="0 0 ${frame_elevation}"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only base_link should be jointed to base_footprint. the spacers should never be jointed to base_footprint. the entire robot should be functional without base_footprint, which is only a virtual helper link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiriamCalafa i now observe that this is something that is coming from work that was done before you but please try to to fix this. the general issue appears to be that in the file urdf/gen3/base.urdf.xacro the property base_elevation doesn't make sense as-is. i don't know where the origin of your frame_module_pla.STL is but most logical base_link origin location is either at the bottom of this link or in the middle of this link in the z-direction. ground clearance should not matter at all. we don't build a robot from the ground, we build it from its base_link. every link/component of the robot should either directly or via some other link be related to the base_link, and never to the base_footprint. the base_footprint defines where is the ground plane related to the robot's base_link. can you revisit the entire gen3/base.urdf.xacro file and fix geometrical relations than currently make use of this frame_elevation or frame_ground_clearance for no good reason.
it might turn our that the variable frame_elevation is completely useless and can be deleted.
here are some lines that need revising in my opinion but there might be others:

<xacro:property name="frame_elevation" value="${frame_height / 2 + frame_ground_clearance}"/>

<origin rpy="0 0 ${pi/2}" xyz="0 0 ${frame_elevation}"/>

<origin rpy="${pi/2} 0 ${pi/2}" xyz="0 0 ${frame_elevation}"/>

<origin rpy="0 0 ${pi/2}" xyz="0 0 ${frame_elevation}"/>

<parent link="${prefix}base_footprint"/>
<child link="${prefix}base_link_spacers"/>
<origin xyz="0 0 0" rpy="0 0 ${frame_elevation}"/>

<origin xyz="0.0025 0 ${frame_ground_clearance + pcb_offset}" rpy="0 ${pi / 2} 0"/>

<origin
xyz="0.0075 0.115 ${frame_ground_clearance + frame_height - e_button_offset}"

xyz="-0.0472 0.111 ${frame_ground_clearance + frame_height - 0.001}"

xyz="-0.07 0.12 ${frame_ground_clearance + frame_height - 0.007}"

xyz="0.08 0 ${frame_ground_clearance + frame_height + 0.0025}"

xyz="-0.0325 0.1185 ${frame_ground_clearance + frame_height-0.0015}"

kruusamae

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants