Dev sprint 137

.github/copilot-instructions.md

@@ -0,0 +1,70 @@
+---
+applyTo: "sdk/src/main/aidl/com/robotemi/sdk/ISdkService.aidl,sdk/src/main/aidl/com/robotemi/sdk/ISdkServiceCallback.aidl"
+---
+
+# AIDL Interface Compatibility Rules
+
+### For `sdk/src/main/aidl/com/robotemi/sdk/ISdkService.aidl` and `sdk/src/main/aidl/com/robotemi/sdk/ISdkServiceCallback.aidl`
+
+**CRITICAL COMPATIBILITY REQUIREMENTS:**
+
+1. **Adding New Interface Methods:**
+   - ⚠️ **ALWAYS add new methods at the END of the interface**
+   - ❌ **NEVER insert methods in the middle of existing methods**
+   - This maintains binary compatibility with existing implementations
+
+2. **Extending Existing Method Parameters:**
+   - ⚠️ **ALWAYS add new parameters at the END of the method signature**
+   - ❌ **NEVER insert parameters in the middle of existing parameters**
+   - This ensures backward compatibility with existing callers
+
+3. **Default Values for New Parameters:**
+   - `int` parameters: default value is `0`
+   - `String` parameters: default value is `null`
+   - `boolean` parameters: default value is `false`
+   - Always consider the impact of these defaults on existing functionality
+
+### Examples:
+
+✅ **CORRECT - Adding new method at the end:**
+```aidl
+interface ISdkService {
+    // ... existing methods ...
+
+    // NEW METHOD - added at the end
+    void newMethod(in String parameter);
+}
+```
+
+❌ **INCORRECT - Adding method in the middle:**
+```aidl
+interface ISdkService {
+    void existingMethod1();
+    void newMethod(in String parameter); // ❌ BREAKS COMPATIBILITY
+    void existingMethod2();
+}
+```
+
+✅ **CORRECT - Extending method parameters at the end:**
+```aidl
+// Before
+void goTo(in String location, int backwards, int noBypass);
+
+// After - new parameter added at the end
+void goTo(in String location, int backwards, int noBypass, in String newParameter);
+```
+
+❌ **INCORRECT - Adding parameter in the middle:**
+```aidl
+// ❌ BREAKS COMPATIBILITY
+void goTo(in String location, in String newParameter, int backwards, int noBypass);
+```
+
+### When Making Changes:
+
+1. Always review the current method order before adding new methods
+2. Consider the impact of default values on existing implementations
+3. Test compatibility with existing applications
+4. Document any breaking changes in release notes
+
+These rules are essential for maintaining backward compatibility with existing Temi robot applications.

gradle.properties

@@ -25,7 +25,7 @@ android.defaults.buildfeatures.buildconfig=true
 android.nonFinalResIds=false
 
 GROUP=com.robotemi
-VERSION_NAME=1.136.0
+VERSION_NAME=1.137.0.10-SNAPSHOT
 POM_URL=https://github.com/robotemi/sdk/
 POM_SCM_URL=https://github.com/robotemi/sdk/
 POM_SCM_CONNECTION=scm:git:git://github.com/robotemi/sdk.git

sample/build.gradle

@@ -6,6 +6,9 @@ repositories {
     maven {
         url 'https://oss.sonatype.org/content/repositories/snapshots/'
     }
+    maven {
+        url 'https://central.sonatype.com/repository/maven-snapshots/'
+    }
 }
 
 android {
@@ -63,4 +66,5 @@ dependencies {
     implementation project(':sdk')
 //    implementation 'com.robotemi:sdk:1.134.1'
     implementation 'com.google.code.gson:gson:2.9.0'
+    implementation 'androidx.core:core-ktx:1.8.0'
 }

sample/src/main/java/com/robotemi/sdk/sample/EditDialog.kt

@@ -0,0 +1,74 @@
+package com.robotemi.sdk.sample
+
+import android.app.Dialog
+import android.content.Context
+import android.os.Bundle
+import android.view.LayoutInflater
+import android.view.View
+import android.view.ViewGroup
+import android.view.inputmethod.InputMethodManager
+import android.widget.BaseAdapter
+import android.widget.Button
+import android.widget.EditText
+import android.widget.ListView
+import androidx.core.widget.doAfterTextChanged
+
+class EditDialog(
+    context: Context, private val locations: MutableList<String>,
+    private val editorActionListener: EditorActionListener
+) : Dialog(context) {
+    private lateinit var listView: ListView
+    private lateinit var confirmBtn: Button
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        setContentView(R.layout.dialog_edit_locations)
+        listView = findViewById(R.id.listView)
+        val adapter = EditableListAdapter(
+            context,
+            locations
+        )
+        listView.adapter = adapter
+        confirmBtn = findViewById(R.id.confirmBtn)
+        confirmBtn.setOnClickListener {
+            editorActionListener.editCompleted(this, adapter.oldText, adapter.newText)
+        }
+    }
+
+    override fun dismiss() {
+        val view = currentFocus
+        if (view is EditText) {
+            val imm = context.getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
+            imm.hideSoftInputFromWindow(view.windowToken, 0)
+        }
+        super.dismiss()
+    }
+    class EditableListAdapter(
+        private val context: Context,
+        private val dataList: MutableList<String>
+    ) : BaseAdapter() {
+        var newText: String = ""
+        var oldText: String = ""
+
+        override fun getCount(): Int = dataList.size
+        override fun getItem(position: Int): Any = dataList[position]
+        override fun getItemId(position: Int): Long = position.toLong()
+
+        override fun getView(position: Int, convertView: View?, parent: ViewGroup): View {
+            val view = convertView ?: LayoutInflater.from(context)
+                .inflate(R.layout.item_editable_dialog_row, parent, false)
+
+            val editText = view.findViewById<EditText>(R.id.name)
+            editText.setText(dataList[position])
+
+            editText.doAfterTextChanged {
+                oldText = dataList[position]
+                newText = it.toString()
+            }
+            return view
+        }
+    }
+
+    interface EditorActionListener {
+        fun editCompleted(editDialog: EditDialog, oldName: String, newName: String)
+    }
+}