fix: asset product info type#1310
Open
christopher-buss wants to merge 1 commit intoroblox-ts:masterfrom
Open
Conversation
Dionysusnu
reviewed
Oct 25, 2024
| interface AssetProductInfo extends ProductInfo { | ||
| /** Describes whether the asset is a User Product, Developer Product, or Game Pass */ | ||
| ProductType: "User Product"; | ||
| ProductType?: "Collectible Item" | "User Product"; |
Contributor
There was a problem hiding this comment.
Is this the right way to change the type? Looking at your screenshot, Collectible Item has a handful of other fields, like CanBeSoldInThisGame, CollectibleItemId and SaleLocation. (Though perhaps the first and last of those exist for other asset types too?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an item is currently not on sale, then the product type will not necessarily exist. "Collectible Item" is also a valid type for assets.