Skip to content

Include gradle fix #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SalehMahmood wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Include gradle fix #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5afe596
Revert install hooks modifying build.gradle
qureshius Sep 17, 2018
7044fda
Fixed include.gradle
qureshius Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ demo/lib
demo/platforms
demo/node_modules
node_modules
!lib/postinstall.js
!*-hooks.js
.DS_Store
115 changes: 0 additions & 115 deletions lib/postinstall.js
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@
"demo.ios": "npm run preparedemo && cd demo && tns run ios",
"demo.android": "npm run preparedemo && cd demo && tns run android",
"preparedemo": "npm run build && cd demo && tns plugin remove nativescript-onesignal && tns plugin add .. && tns install",
"setup": "npm i && cd demo && npm i && cd .. && npm run build && cd demo && tns plugin add .. && cd ..",
"postinstall": "node postinstall-hooks.js && node lib/postinstall.js",
"preuninstall": "node preuninstall-hooks.js"
"setup": "npm i && cd demo && npm i && cd .. && npm run build && cd demo && tns plugin add .. && cd .."
},
"devDependencies": {
"tns-core-modules": "^2.2.0",
Expand Down
10 changes: 7 additions & 3 deletions platforms/android/include.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@ buildscript {
}
dependencies {
// https://github.com/OneSignal/OneSignal-Gradle-Plugin
classpath 'gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.10.1, 0.99.99]'
classpath 'gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.11.0, 0.99.99]'
}
}
apply plugin: com.onesignal.androidsdk.GradleProjectPlugin
apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin'

repositories {
maven { url 'https://maven.google.com' }
}

android {
productFlavors {
Expand All @@ -27,5 +31,5 @@ android {
}

dependencies {
compile 'com.onesignal:OneSignal:3.9.1'
compile 'com.onesignal:OneSignal:[3.9.1, 3.99.99]'
}
4 changes: 0 additions & 4 deletions postinstall-hooks.js
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions preuninstall-hooks.js
View file
Open in desktop

This file was deleted.