feat: session scrollback with mouse wheel scroll#44
Merged
Conversation
Header shortcuts bar, n-key session spawning, and full-height centered card layout.
9 tasks covering header bar, n-key session spawning, and full-height centered card layout with TDD steps.
Resolves merge conflicts between header bar, n-key session, and full-height layout branches.
- Add max card height (12) and max card width (50) to prevent cards from stretching across the full terminal - Add 2-character column gaps between cards in the grid - Add 's' keybinding to toggle session selection (pin/unpin) - Show checkmark indicator on pinned session cards - Extract named constants for magic numbers in card rendering
…vements # Conflicts: # internal/tui/app_view.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PTYSessionwith mutex-protectedScrollUp/ScrollDown/ScrollToBottommethodstea.MouseMsgwheel events inUpdate()to scroll the active PTY session panel↓ N lines below) when a session is scrolled upTestPTYSessionStartAndRender(snapshot messages under lock)Test plan
golangci-lint run— 0 issuesgo test ./... -v -race— 112 tests pass, 0 race conditionsgo build -o dj ./cmd/dj— exit 0