Hide close button feature #20
Conversation
| fileprivate var closeButton: LYHoverButton! | ||
|
|
||
| public var showCloseButton: Bool = true | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| } | ||
| } | ||
|
|
||
| public var showCloseButton: Bool = true |
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| resetHeight() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| self.tabBarView.addNewTabButtonTarget = self | ||
|
|
||
| self.tabBarView.showCloseButton = false | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| tabBarView?.addNewTabButtonAction = #selector(addNewTab) | ||
| } | ||
| self.tabBarView.addNewTabButtonTarget = self | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 3. (vertical_whitespace)
| self.tabBarView.minTabItemWidth = 120 | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| self.tabBarView.minTabHeight = 28 | ||
| self.tabBarView.minTabItemWidth = 120 | ||
|
|
||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| tabItemView.selectedBackgroundColor = self.selectedBackgroundColor | ||
| tabItemView.unselectedForegroundColor = self.unselectedForegroundColor | ||
| tabItemView.closeButtonHoverBackgroundColor = self.closeButtonHoverBackgroundColor | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| .windowInactive: NSColor(white: 0.4, alpha: 1), | ||
| .inactive: NSColor(white: 0.4, alpha: 1) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| .windowInactive: NSColor(white: 0.96, alpha: 1), | ||
| .inactive: NSColor(white: 0.76, alpha: 1) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| .windowInactive: NSColor(white: 0.94, alpha: 1), | ||
| .inactive: NSColor(white: 0.68, alpha: 1) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| .windowInactive: NSColor(white: 0.86, alpha: 1), | ||
| .inactive: NSColor(white: 0.70, alpha: 1) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| .windowInactive: NSColor(white: 0.86, alpha: 1), | ||
| .inactive: NSColor(white: 0.71, alpha: 1) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
|
|
||
| self.tabBarView.showCloseButton = false | ||
|
|
||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
2 participants
New showCloseButton feature. I did this because I wanted to show tabs, but I do not want the user to be able to close them.