NodeJS 10.x compatibility

[kaij]

Unfortunately, NodeJS >=9.11.0 introduces the socket event "ready", which is also used as a custom event in the code. Renamed this event (plus deprecated buffer constructors) to make lib work with NodeJS 10.x

[mfreeman-xtivia]

Could I please add a +1 to get this PR added to the baseline?

I spent hours and hours chasing down why this library "broke" after a node upgrade, only to come to the exact same conclusion, i.e. the use of the internal event "ready" here has been co-opted by a system event of the same name.

Would really prefer to avoid having to use a fork for the sake of 2 lines of changes. Thanks

[mfreeman-xtivia]

Alrighty then, since its crickets here guess I'm off to create my own fork....

[yuchi]

Just a small note: @robframpton created this package as part of the Liferay Theme SDK, but has since moved from the company.

Probably he should move the ownership of the repo and npm module to Liferay.

I'll try to contact some one.

[izaera]

Hey guys: I’m planning to move all that code to a library of its own or to liferay-npm-build-tools because it may also be used from the bundler in the future, but we haven’t had time yet.

We've been busy preparing the events (DEVCON, LSNA, Spain & Italy Sympo, ...) and @jbalsas is not available for the next two weeks 😓 . I guess we can have a look at it then...