Feature/v2 Make ProgressBar accept breakpoints#2
Open
robesonck wants to merge 1 commit intofeature/v1from
Open
Feature/v2 Make ProgressBar accept breakpoints#2robesonck wants to merge 1 commit intofeature/v1from
robesonck wants to merge 1 commit intofeature/v1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This request solves V2 of the Progress Bar Exercise.
Where should the reviewer start?
src/progress_bar_exercise/ProgressBarExercise.jssrc/progress_bar_exercise/components/ProgressBar/useProgressBarState.jssrc/progress_bar_exercise/components/ProgressBar/ProgressBar.jsChanges:
BreakPointFillercomponent to be able to choose the breakpoints with a user friendly UI. This component shouldn't go to production, it's only there to make testing of the breakpoints easier. The usage of this component is as follows:Screen.Recording.2021-12-26.at.14.07.02.mov
ProgressBarto work with breakpoints, while keeping the previous behavior intact.The interface to add them is:
Recordings
Here we're first showing the behavior of it working with 2 breakpoints, then adding another one and still working.
Both cases work with the 90% rule too
Screen.Recording.2021-12-26.at.14.13.56.mov
Assumptions